Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hardware Idle support and use it configurably for the Softswitch barrier #297

Draft
wants to merge 47 commits into
base: development
Choose a base branch
from

Conversation

heliosfa
Copy link
Contributor

@heliosfa heliosfa commented Dec 6, 2021

**NOT TO BE REVIEWED UNTIL:**

 
This PR:

 
A more verbose summary:
This PR implements Hardware Idle support in the Orchestrator and Softswitch. Some fairly significant changes to deployment logic have been required in order to support this feature and tweaks to tinsel have been required.

In summary, Hardware Idle requires all threads in the system, whether they have been started or not, to be sat at a call to tinselIdle() for the hardware synchronisation point to be. This is at odds with the existing paradigm in the Orchestrator where binaries are only built and loaded onto used cores and only used threads are started.

To address this, we now build a common dummy binary that facilitates Hardware Idle and define a default behaviour for unused threads. The Mothership now deploys the "dummy" binaries to all cores before deploying application-specific binaries to used cores. Changes were also made to Tinsel to enable a common binary to be loaded onto all cores without starting them.

Additionally, the start-up barrier was still found to be a problem for some application types despite the fixes in #248. To address this, we make use of the Hardware Idle feature as an (optional) way to implement barrier release. This behaviour is configurable prior to compilation with two new Composer commands:

  • compose /hwbarrier = * enables the Hardware Idle barrier. This is now the default behaviour.
  • compoae /swbarrier = * disabled the Hardware Idle barrier and falls back to existing behaviour.

As an extra bonus, this PR also implements support for doSend in the Send Handler and fixes #309. This PR also emits the "global" RTS flags and indices (into MessageFormats.h) as required by #308.

 
Testing:
The basic behaviour of Hardware Idle has been tested with a new Hardware Idle simple test (included in POETSII/Orchestrator_examples#15).

The modified barrier release has been extensively tested with the GALS Arithmetic application (pending commit to the Examples repository) at various sizes between 25 and 250,000 devices deployed with the spread algorithm. There were zero instances of an application failing to be released from the barrier.

The basic behaviour of doSend has been tested with a new doSend simple test (included in POETSII/Orchestrator_examples#15).

The functionality of the global RTS variables has been checked with clock_tree_broad_s2.v4.xml from the 2019 benchmarks

 
Conflicts:
This changeset potentially makes #262 easier as we can discriminate between the barrier releasing naturally or being broken by an inbound packet. Care is required.

This changeset makes multi-application runs significantly harder.

This changeset makes implementing support for multiple supervisors more involved and will likely require changes to Tinsel.

heliosfa and others added 30 commits July 5, 2021 04:06
… discriminate between when we are supposed to support hardware idle, and when we are not.
… the Mothership know. The Mothership will use global backend 'start' and 'go' methods instead.
…e at deploy time. It causes a Mothership to call backend's loadAll method.
…TSII/Orchestrator into FEATURE-0242-HardwareIdle-Mothership
@heliosfa heliosfa added bug Report of a bug feature New feature composer Issues related to the Composer softswitch Issues related to the Softswitch labels Dec 6, 2021
@heliosfa heliosfa self-assigned this Dec 6, 2021
@heliosfa heliosfa marked this pull request as draft December 6, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a bug composer Issues related to the Composer feature New feature softswitch Issues related to the Softswitch
Projects
None yet
2 participants