getDataLabel defends against empty labels

Author: yfinkel

src/PhpSpreadsheet/Chart/Renderer/JpGraphRendererBase.php

@@ -281,6 +281,16 @@ private function renderRadarPlotArea(): void
         $this->renderTitle();
     }
 
+    private function getDataLabel(int $groupId, int $index): mixed
+    {
+        $plotLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupId)->getPlotLabelByIndex($index);
+        if (!$plotLabel) {
+            return '';
+        } else {
+            return $plotLabel->getDataValue();
+        }
+    }
+
     private function renderPlotLine(int $groupID, bool $filled = false, bool $combination = false): void
     {
         $grouping = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotGrouping();
@@ -334,10 +344,8 @@ private function renderPlotLine(int $groupID, bool $filled = false, bool $combin
                 //    Set the appropriate plot marker
                 $this->formatPointMarker($seriesPlot, $marker);
             }
-            if ($this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($index)) {
-                $dataLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($index)->getDataValue();
-                $seriesPlot->SetLegend($dataLabel);
-            }
+
+            $seriesPlot->SetLegend($this->getDataLabel($groupID, $index));
 
             $seriesPlots[] = $seriesPlot;
         }
@@ -410,12 +418,8 @@ private function renderPlotBar(int $groupID, ?string $dimensions = '2d'): void
             if ($dimensions == '3d') {
                 $seriesPlot->SetShadow();
             }
-            if (!$this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($j)) {
-                $dataLabel = '';
-            } else {
-                $dataLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($j)->getDataValue();
-            }
-            $seriesPlot->SetLegend($dataLabel);
+
+            $seriesPlot->SetLegend($this->getDataLabel($groupID, $j));
 
             $seriesPlots[] = $seriesPlot;
         }
@@ -494,8 +498,7 @@ private function renderPlotScatter(int $groupID, bool $bubble): void
                 $marker = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotValuesByIndex($i)->getPointMarker();
                 $this->formatPointMarker($seriesPlot, $marker);
             }
-            $dataLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($i)->getDataValue();
-            $seriesPlot->SetLegend($dataLabel);
+            $seriesPlot->SetLegend($this->getDataLabel($groupID, $i));
 
             $this->graph->Add($seriesPlot);
         }
@@ -526,13 +529,12 @@ private function renderPlotRadar(int $groupID): void
 
             $seriesPlot = new RadarPlot(array_reverse($dataValuesX));
 
-            $dataLabel = $this->chart->getPlotArea()->getPlotGroupByIndex($groupID)->getPlotLabelByIndex($i)->getDataValue();
             $seriesPlot->SetColor(self::$colourSet[self::$plotColour++]);
             if ($radarStyle == 'filled') {
                 $seriesPlot->SetFillColor(self::$colourSet[self::$plotColour]);
             }
             $this->formatPointMarker($seriesPlot, $marker);
-            $seriesPlot->SetLegend($dataLabel);
+            $seriesPlot->SetLegend($this->getDataLabel($groupID, $i));
 
             $this->graph->Add($seriesPlot);
         }