Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong input parameter object type in setHyperlink() #23

Closed
nynka opened this issue May 16, 2014 · 1 comment
Closed

Wrong input parameter object type in setHyperlink() #23

nynka opened this issue May 16, 2014 · 1 comment

Comments

@nynka
Copy link

nynka commented May 16, 2014

Documentation suggests that function setHyperlink() receives a PHPPowerPoint_Shape_Hyperlink object as input parameter but the function receives a PHPExcel_Cell_Hyperlink object in PHPPowerPoint_Shape_RichText_TextElement on line 124.

The same applies for PHPPowerPoint_Shape on line 379.

/**
 * Set Hyperlink
 *
 * @param   PHPPowerPoint_Shape_Hyperlink   $pHyperlink
 * @throws  Exception
 * @return PHPPowerPoint_Shape
 */
public function setHyperlink(PHPExcel_Cell_Hyperlink $pHyperlink = null)
{
  $this->_hyperlink = $pHyperlink;
  return $this;
}
@Progi1984 Progi1984 added this to the 0.2.0 milestone May 16, 2014
@Progi1984
Copy link
Member

Corrected in develop branch.

@Progi1984 Progi1984 self-assigned this Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants