From 13ee209d229e5ebdc0514259bfd2917b48b27b6e Mon Sep 17 00:00:00 2001
From: Rodrigo Primo <rodrigosprimo@gmail.com>
Date: Fri, 5 Jan 2024 14:43:17 -0300
Subject: [PATCH 1/4] Generic/RequireStrictTypes: add XML documentation

---
 .../Docs/PHP/RequireStrictTypesStandard.xml   | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml

diff --git a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
new file mode 100644
index 0000000000..e46b0c7705
--- /dev/null
+++ b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
@@ -0,0 +1,27 @@
+<documentation title="Require Strict Types">
+    <standard>
+    <![CDATA[
+    The strict_types declaration must be present and enabled.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: strict_types declaration is present and enabled.">
+        <![CDATA[
+<?php
+declare(<em>strict_types=1</em>);
+
+<?php
+declare(ticks=1, <em>strict_types=1</em>);
+        ]]>
+        </code>
+        <code title="Invalid: Missing or disabled strict_types declaration.">
+        <![CDATA[
+<?php
+declare(encoding='ISO-8859-1'<em></em>);
+
+<?php
+declare(strict_types=<em>0</em>);
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From 6203a1be6da3400c5609e1d5fdfbb6f84c03c50f Mon Sep 17 00:00:00 2001
From: Rodrigo Primo <rodrigosprimo@gmail.com>
Date: Mon, 15 Jan 2024 16:20:18 -0300
Subject: [PATCH 2/4] Rough draft of how the docs look like separating the two
 rules

---
 .../Docs/PHP/RequireStrictTypesStandard.xml   | 31 +++++++++++++++++--
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
index e46b0c7705..7a25ddda3c 100644
--- a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
+++ b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
@@ -1,24 +1,49 @@
 <documentation title="Require Strict Types">
     <standard>
     <![CDATA[
-    The strict_types declaration must be present and enabled.
+    The strict_types declaration must be present.
     ]]>
     </standard>
     <code_comparison>
-        <code title="Valid: strict_types declaration is present and enabled.">
+        <code title="Valid: strict_types declaration is present.">
         <![CDATA[
 <?php
 declare(<em>strict_types=1</em>);
 
 <?php
 declare(ticks=1, <em>strict_types=1</em>);
+
+<?php
+declare(<em>strict_types=0</em>);
         ]]>
         </code>
-        <code title="Invalid: Missing or disabled strict_types declaration.">
+        <code title="Invalid: Missing strict_types declaration.">
         <![CDATA[
 <?php
 declare(encoding='ISO-8859-1'<em></em>);
 
+<?php
+declare(strict_types=<em>0</em>);
+        ]]>
+        </code>
+    </code_comparison>
+    <standard>
+    <![CDATA[
+    The strict_types declaration must be enabled.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: strict_types declaration is enabled.">
+        <![CDATA[
+<?php
+declare(<em>strict_types=1</em>);
+
+<?php
+declare(ticks=1, <em>strict_types=1</em>);
+        ]]>
+        </code>
+        <code title="Invalid: strict_types declaration is disabled.">
+        <![CDATA[
 <?php
 declare(strict_types=<em>0</em>);
         ]]>

From 70bea750a63b3220f5c918d810d122798f8d481f Mon Sep 17 00:00:00 2001
From: Rodrigo Primo <rodrigosprimo@gmail.com>
Date: Fri, 23 Feb 2024 10:40:43 -0300
Subject: [PATCH 3/4] Generic/RequireStrictTypes: improve docs based on PR
 review suggestions

---
 .../Docs/PHP/RequireStrictTypesStandard.xml      | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
index 7a25ddda3c..e4361220df 100644
--- a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
+++ b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
@@ -7,23 +7,16 @@
     <code_comparison>
         <code title="Valid: strict_types declaration is present.">
         <![CDATA[
-<?php
 declare(<em>strict_types=1</em>);
 
-<?php
-declare(ticks=1, <em>strict_types=1</em>);
-
-<?php
-declare(<em>strict_types=0</em>);
+declare(encoding='UTF-8', <em>strict_types=0</em>);
         ]]>
         </code>
         <code title="Invalid: Missing strict_types declaration.">
         <![CDATA[
-<?php
 declare(encoding='ISO-8859-1'<em></em>);
 
-<?php
-declare(strict_types=<em>0</em>);
+declare(ticks=1<em></em>);
         ]]>
         </code>
     </code_comparison>
@@ -35,16 +28,11 @@ declare(strict_types=<em>0</em>);
     <code_comparison>
         <code title="Valid: strict_types declaration is enabled.">
         <![CDATA[
-<?php
 declare(<em>strict_types=1</em>);
-
-<?php
-declare(ticks=1, <em>strict_types=1</em>);
         ]]>
         </code>
         <code title="Invalid: strict_types declaration is disabled.">
         <![CDATA[
-<?php
 declare(strict_types=<em>0</em>);
         ]]>
         </code>

From c7f8834dfbd47f61200c8a5c5569503e00c1a20f Mon Sep 17 00:00:00 2001
From: Rodrigo Primo <rodrigosprimo@gmail.com>
Date: Fri, 23 Feb 2024 10:43:01 -0300
Subject: [PATCH 4/4] Generic/RequireStrictTypes: further improvements to the
 docs

Remove one redundant invalid example and make one highlight more
meaningful.
---
 src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
index e4361220df..701cb484e0 100644
--- a/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
+++ b/src/Standards/Generic/Docs/PHP/RequireStrictTypesStandard.xml
@@ -15,8 +15,6 @@ declare(encoding='UTF-8', <em>strict_types=0</em>);
         <code title="Invalid: Missing strict_types declaration.">
         <![CDATA[
 declare(encoding='ISO-8859-1'<em></em>);
-
-declare(ticks=1<em></em>);
         ]]>
         </code>
     </code_comparison>
@@ -28,7 +26,7 @@ declare(ticks=1<em></em>);
     <code_comparison>
         <code title="Valid: strict_types declaration is enabled.">
         <![CDATA[
-declare(<em>strict_types=1</em>);
+declare(strict_types=<em>1</em>);
         ]]>
         </code>
         <code title="Invalid: strict_types declaration is disabled.">