Fixed PHP tokenizer problem that caused an infinite loop when checking a comment with specific content

Author: gsherwood

CodeSniffer/Standards/Squiz/Tests/PHP/CommentedOutCodeUnitTest.inc

@@ -83,3 +83,5 @@ function myFunction()
 // http://www.google.com
 
 // Base config function.
+
+// function ()

CodeSniffer/Standards/Squiz/Tests/PHP/CommentedOutCodeUnitTest.php

@@ -64,6 +64,7 @@ public function getWarningList($testFile='CommentedOutCodeUnitTest.inc')
                     8  => 1,
                     15 => 1,
                     19 => 1,
+                    87 => 1,
                    );
             break;
         case 'CommentedOutCodeUnitTest.css':

CodeSniffer/Tokenizers/PHP.php

@@ -1014,7 +1014,7 @@ public function processAdditional(&$tokens, $eolChar)
 
                     $tokenAfterReturnTypeHint = $tokens[$i]['scope_opener'];
                 } else if (isset($tokens[$i]['parenthesis_closer']) === true) {
-                    for ($x = ($tokens[$i]['parenthesis_closer'] + 1); $i < $numTokens; $x++) {
+                    for ($x = ($tokens[$i]['parenthesis_closer'] + 1); $x < $numTokens; $x++) {
                         if ($tokens[$x]['code'] === T_SEMICOLON) {
                             $tokenAfterReturnTypeHint = $x;
                             break;

package.xml

@@ -48,6 +48,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
     -- Removes the error Squiz.Commenting.ClassComment.SpaceBefore
   - Renamed Squiz.CSS.Opacity.SpacingAfterPoint to Squiz.CSS.Opacity.DecimalPrecision
     -- Please update your ruleset if you are referencing this error code directly
+  - Fixed PHP tokenizer problem that caused an infinite loop when checking a comment with specific content
   - Squiz CSS IndentationSniff no longer assumes the class opening brace is at the end of a line
   - Squiz FunctionCommentThrowTagSniff now ignores non-docblock comments
   - Squiz ComparisonOperatorUsageSniff now allows conditions like while(true)