Merge pull request moov-io#43 from dmlambea/signer_from_doc

adamdecaf · web-flow · commit 88b12dfd4b0a · 2023-08-01T09:06:20.000-05:00
signer: add convenience method for creating a signer given an already built etree.Document
diff --git a/signer.go b/signer.go
@@ -52,6 +52,11 @@ func NewSigner(xml string) (*Signer, error) {
 	if err != nil {
 		return nil, err
 	}
+	return NewSignerFromDoc(doc)
+}
+
+// NewSignerFromDoc returns a *Signer for the Document provided
+func NewSignerFromDoc(doc *etree.Document) (*Signer, error) {
 	s := &Signer{signatureData: signatureData{xml: doc}}
 	return s, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,11 @@ func NewSigner(xml string) (*Signer, error) {`
`52`	`52`	`if err != nil {`
`53`	`53`	`return nil, err`
`54`	`54`	`}`
	`55`	`+ return NewSignerFromDoc(doc)`
	`56`	`+}`
	`57`	`+`
	`58`	`+// NewSignerFromDoc returns a *Signer for the Document provided`
	`59`	`+func NewSignerFromDoc(doc etree.Document) (Signer, error) {`
`55`	`60`	`s := &Signer{signatureData: signatureData{xml: doc}}`
`56`	`61`	`return s, nil`
`57`	`62`	`}`