Sparrow dom/rewards active campaign #4263
Conversation
| @@ -210,7 +210,7 @@ services: | |||
| command: | |||
| > | |||
| /bin/bash -c "wait-for.sh -t 0 -q elasticsearch:9200 -- | |||
| wait-for.sh -t 0 -q services:1111 -- | |||
| wait-for.sh -t 0 -q services:8545 -- | |||
There was a problem hiding this comment.
@mikeshultz have changed this back from port 1111 to 8454. It was preventing some of the services in docker to start up.
There was a problem hiding this comment.
Perhaps because something with services isn't working? This is preventing other services from coming up because some dependency services (probably) isn't coming up. It specifically brings up an empty service on port 1111 to indicate that everything is good to go:
origin/packages/services/index.js
Line 461 in 2334d4e
By checking 8545(ganache), you're skipping basically every other service that it brings up. I'd recommend looking into the cause of your issue instead of making this change.
There was a problem hiding this comment.
Ah thanks @mikeshultz The problem was with identity contract not deploying. Fix here:
#4274
|
@micahalcorn @franckc currently I have it set to this: Happy to change it if needed. |
|
Thanks @sparrowDom 👍 Should we link to the blog post there announcing the early end? |
…rotocol/origin into sparrowDom/rewardsActiveCampaign
|
@micahalcorn was thinking about linking to the blog post, but we will show this screen anytime where there is no active campaigns. The block post link might be outdated with the next occurrence when we close a campaign early. |
…rotocol/origin into sparrowDom/rewardsActiveCampaign
|
Chatted with @joshfraser - he recommends we put a link to the blogpost and to our telegram english channel. We'll have to update the blog post link in the future... but this is still worth doing to in order to minimize the amount of users inquiries in the short-term. |
|
@micahalcorn Could you please check the copies before I merge this in? Thanks:) |
Fixes: #4259
Checklist:
fbtfor translationnpm run translate