Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Implement pseudo-localization #397

Open
jordajm opened this issue Aug 14, 2018 · 1 comment
Open

Implement pseudo-localization #397

jordajm opened this issue Aug 14, 2018 · 1 comment
Labels
dapp dev environment good first issue Good for newcomers javascript P4 Something to consider, a feature request that we may not pursue

Comments

@jordajm
Copy link
Contributor

jordajm commented Aug 14, 2018

When developing a new feature in the DApp, it may be helpful to be able to view the component with longer/taller strings to identify inflexible containers and make sure they can handle non-english strings. Otherwise, we have to wait until translators complete translation of the new strings, which will usually not be available until after the feature is released.

Inspired by this blog post from Netflix:
https://medium.com/netflix-techblog/pseudo-localization-netflix-12fff76fbcbe

Here's someone's open-source implementation of the concepts in that blog post:
https://www.npmjs.com/package/pseudo-localization

We could trigger pseudo-localization via a query string like ?localize=true or some other method.

@wanderingstan
Copy link
Contributor

wanderingstan commented Aug 15, 2018

Interesting.

Since we already have react-intl wired up, I think that putting the npm module in the DApp is not the right move; it doesn't "know" which strings have been wrapped for localization, and adds another dependency to the DApp.

Could we instead add the package to your processTranslatedMessages.js script, creating an additional "language" called "Pseudo Localization", build from our English strings, that we only enable on non-production builds?

https://github.com/OriginProtocol/origin-dapp/blob/master/translations/scripts/processTranslatedMessages.js


EDIT: But that said, I don't know if this is a priority. In my experience, 99% of translations issues can be found by testing German (for length) and Chinese (for odd characters). Since we can get instant machine-translated versions of these, that's good enough to get testing going even before real human translations are complete.

@micahalcorn micahalcorn added the P4 Something to consider, a feature request that we may not pursue label Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dapp dev environment good first issue Good for newcomers javascript P4 Something to consider, a feature request that we may not pursue
Projects
None yet
Development

No branches or pull requests

3 participants