Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add ENS support to our DApp #239

Open
joshfraser opened this issue May 29, 2018 · 6 comments
Open

Add ENS support to our DApp #239

joshfraser opened this issue May 29, 2018 · 6 comments
Labels
discussion enhancement New feature or request good first issue Good for newcomers P3 Users are not significantly affected, minor cosmetic issue

Comments

@joshfraser
Copy link
Contributor

We should use the ENS reverse resolver to show ENS names in the DApp whenever possible.

Apparently this is the best library for us to use:
https://www.npmjs.com/package/ethereum-ens

Open questions:

  • Do we want to put ENS support at the DApp level or should we bake it into Origin.js?
  • Do we want to show an ENS name in place of an ETH address or do we want to display both?
@joshfraser joshfraser added enhancement New feature or request good first issue Good for newcomers feature discussion and removed feature labels May 29, 2018
@micahalcorn
Copy link
Member

I vote for replacing raw addresses with ENS when available.

@micahalcorn
Copy link
Member

It would be great to abstract this into Origin.js so that the ENS name is returned as an attribute on a user. I think it's fine for a proof-of-concept to start out at the DApp level, if necessary.

@gustavoguimaraes
Copy link

I would like to take on this issue. Is it still relevant given the current Q1 priorities?

@micahalcorn micahalcorn added the P3 Users are not significantly affected, minor cosmetic issue label Apr 11, 2019
@micahalcorn
Copy link
Member

micahalcorn commented Jun 30, 2019

Just a note to say that we no longer have Origin.js as described above 😐

Any updated thoughts on this proposed feature @joshfraser @nick?

@nick
Copy link
Contributor

nick commented Jul 1, 2019

I'm not sure ENS is used widely enough to bother... perhaps we can try to resolve every wallet that has interacted with our marketplace to see how many resolve? Even so, now that we're moving away from showing wallet addresses in the dapp this may not be worth the time to implement.

@joshfraser
Copy link
Contributor Author

Low priority, but I think it's still worth doing at some point. Should be fairly trivial to implement and would give us some extras points within the Ethereum community.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion enhancement New feature or request good first issue Good for newcomers P3 Users are not significantly affected, minor cosmetic issue
Projects
None yet
Development

No branches or pull requests

4 participants