Listing Expiration

[micahalcorn]

Since overhauling the contracts, we no longer have listing expiration as a feature. It was previously set at the contract level to 60 days. Do will still want this to be the case? Nick mentioned doing it in IPFS.

Related: OriginProtocol/origin-js#72

[DanielVF]

I think it's important to have an expectation that listings aren't forever, at least for the early days of origin.

Expiration Pro's:

• From an end user's point of view, they don't have to wonder as quite as much if the listing is still actually for sale or not.
• By expiring old listings, we can painlessly sunset old contract APIs in the early days. This will make our lives much easier.

Cons:

• There are certainly some kinds of listings that could benefit from staying online for a while - I just think we should wait to roll that out until later.
• Will make it look like there are fewer listings in the system.

Implementation:

• With the new contract architecture, we could possibly just implement this in the search server + a message in the DAPP on contract creation.

[nick]

Yea agree we should have expiry but don't think we need to do it at the contract level.

We could just default it to 60 days initially (as long as the seller is made aware) or make it another field on the listing that the seller can edit.

I guess if we do another migration we can skip out old listings, if they're expired anyway?

[micahalcorn]

@matthewliu pointed out that there are a lot of additional consequences now if listings expire. For example, we would want to notify sellers that their listings are about to expire and we may have to handle refunding commissions or stakes. And as @nick points out, not all listings should expire so quickly. X number of days might be too arbitrary. Let's leave this out for Q3 and revisit later.