diff --git a/.github/workflows/functional_all_db.yml b/.github/workflows/functional_all_db.yml index 03790dbe7b1..4fad111036d 100644 --- a/.github/workflows/functional_all_db.yml +++ b/.github/workflows/functional_all_db.yml @@ -31,7 +31,7 @@ jobs: github.event.review.state == 'CHANGES_REQUESTED' runs-on: ubuntu-24.04 container: - image: cypress/included:15.5.0 + image: cypress/included:15.6.0 steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 - uses: ./.github/actions/setup-dotnet @@ -59,7 +59,7 @@ jobs: github.event.review.state == 'CHANGES_REQUESTED' runs-on: ubuntu-24.04 container: - image: cypress/included:15.5.0 + image: cypress/included:15.6.0 env: OrchardCore__OrchardCore_YesSql__EnableThreadSafetyChecks: true steps: @@ -87,7 +87,7 @@ jobs: github.event.review.state == 'CHANGES_REQUESTED' runs-on: ubuntu-24.04 container: - image: cypress/included:15.5.0 + image: cypress/included:15.6.0 services: postgres: image: postgres:11 @@ -130,7 +130,7 @@ jobs: github.event.review.state == 'CHANGES_REQUESTED' runs-on: ubuntu-24.04 container: - image: cypress/included:15.5.0 + image: cypress/included:15.6.0 services: mysql: image: mysql:8 @@ -169,7 +169,7 @@ jobs: github.event.review.state == 'CHANGES_REQUESTED' runs-on: ubuntu-24.04 container: - image: cypress/included:15.5.0 + image: cypress/included:15.6.0 services: mssql: image: mcr.microsoft.com/mssql/server:2019-latest diff --git a/Directory.Packages.props b/Directory.Packages.props index 2e263ae7c1d..a1ffd089837 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -18,7 +18,7 @@ - + @@ -62,8 +62,8 @@ - - + + diff --git a/src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs b/src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs index 409b3a29f12..9f038acdd0d 100644 --- a/src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs +++ b/src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs @@ -17,7 +17,7 @@ using OrchardCore.Shortcodes.Models; using OrchardCore.Shortcodes.Services; using OrchardCore.Shortcodes.ViewModels; -using Parlot; +using Shortcodes; namespace OrchardCore.Shortcodes.Controllers; @@ -347,7 +347,16 @@ public async Task IndexPost(ContentOptions options, IEnumerable ProcessAsync(FluidValue input, FilterArgument return FluidValue.Create(missingUsers.Concat(cachedUsers).ToList(), ctx.Options); } - return NilValue.Empty; + return EmptyValue.Instance; } if (input.Type == FluidValues.Array) diff --git a/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/HtmlContentValue.cs b/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/HtmlContentValue.cs index 75caff2d8c9..e629d5eb714 100644 --- a/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/HtmlContentValue.cs +++ b/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/HtmlContentValue.cs @@ -91,15 +91,4 @@ public override void WriteTo(TextWriter writer, TextEncoder encoder, CultureInfo { _value.WriteTo(writer, (HtmlEncoder)encoder); } - - [Obsolete("GetValue is obsolete, prefer the GetValueAsync method.")] - protected override FluidValue GetValue(string name, TemplateContext context) - { - return NilValue.Instance; - } - - protected override FluidValue GetIndex(FluidValue index, TemplateContext context) - { - return NilValue.Instance; - } } diff --git a/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/StringValuesValue.cs b/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/StringValuesValue.cs index dff13771041..165258c3644 100644 --- a/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/StringValuesValue.cs +++ b/src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/StringValuesValue.cs @@ -131,6 +131,7 @@ public override ValueTask GetValueAsync(string name, TemplateContext return NilValue.Instance; } + [Obsolete("This method has been deprecated, please use GetIndexAsync() instead.")] protected override FluidValue GetIndex(FluidValue index, TemplateContext context) { var i = (int)index.ToNumberValue(); @@ -143,6 +144,11 @@ protected override FluidValue GetIndex(FluidValue index, TemplateContext context return NilValue.Instance; } + // Using the original method for backward compatibility. +#pragma warning disable CS0618 // Type or member is obsolete + public override ValueTask GetIndexAsync(FluidValue index, TemplateContext context) => GetIndex(index, context); +#pragma warning restore CS0618 // Type or member is obsolete + public override bool ToBooleanValue() => true;