Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Add UI tests to detect app crashes #216

Closed
pylapp opened this issue Oct 19, 2024 · 2 comments
Closed

[Tests] Add UI tests to detect app crashes #216

pylapp opened this issue Oct 19, 2024 · 2 comments
Labels
📱 demo app Update of the Demo App 🔨 tool Related to tooling

Comments

@pylapp
Copy link
Member

pylapp commented Oct 19, 2024

Today we cannot check if some tokens are defined but not implemented.

Indeed we defined a system using fatalError to make the app crash if some tokens are embedded without definitions. This is an acceptable last-chance edge case because the design system and the tokenator should manage this case before.

However we cannot know automatically if we embed such declared but not defined tokens. As a consequence we can release app which can crash, #215

We can implement simple UI unit tests so as to check if the app crashes or not. For example, the tests should, for each page, go to each view and subview. Maybe make some assertions. If the app crashes, maybe the tokens are not defined.
The tests can for example iterate on each token in the theme and check if there is a view with this token. With these tests, we will be able to check if app crashes or not, and if some tokens are missing in the display.

@pylapp pylapp added 📱 demo app Update of the Demo App 🔨 tool Related to tooling labels Oct 19, 2024
@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Oct 19, 2024
@pylapp
Copy link
Member Author

pylapp commented Oct 21, 2024

trim.CDEEB949-40C4-4154-9AE9-B6E71324D1E7.MOV

Such types of smoke test

@pylapp
Copy link
Member Author

pylapp commented Nov 29, 2024

Closed issue because not relevant. UI tests implemented by @Tayebsed93 always iterates (if of course updated) on each usable tokens, so if a token is not defined with a fatalError the tests will crash.

@pylapp pylapp closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [OUDS] Project Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📱 demo app Update of the Demo App 🔨 tool Related to tooling
Projects
Status: Done
Development

No branches or pull requests

2 participants