Skip to content

Commit 3b28b89

Browse files
committed
refactor: remove tokens elevationZIndex and add elevationX200 (#119)
Closes #119 Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
1 parent 32a19aa commit 3b28b89

File tree

4 files changed

+14
-21
lines changed

4 files changed

+14
-21
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased](https://github.com/Orange-OpenSource/ouds-ios/compare/0.2.0...develop)
88

9+
### Added
10+
11+
- [Library] Add `elevationX200` raw token ([#119](https://github.com/Orange-OpenSource/ouds-ios/issues/119))
12+
13+
### Removed
14+
15+
- [Library] Remove raw tokens `elevationZIndex` ([#119](https://github.com/Orange-OpenSource/ouds-ios/issues/119))
916

1017
## [0.2.0](https://github.com/Orange-OpenSource/ouds-ios/compare/0.1.0...0.2.0) - 2024-09-19
1118

OUDS/Core/Tokens/RawTokens/Sources/Values/ElevationRawTokens+Values.swift

+1-18
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,10 @@
1515
/// Should be fully generated in the future.
1616
extension ElevationRawTokens {
1717

18-
// MARK: Primitive token - Elevation - Z Index
19-
20-
public static let elevationZIndex0: ElevationRawToken = 0
21-
public static let elevationZIndexMinus9999: ElevationRawToken = -9999
22-
public static let elevationZIndex1000: ElevationRawToken = 1000
23-
public static let elevationZIndex1010: ElevationRawToken = 1010
24-
public static let elevationZIndex1020: ElevationRawToken = 1020
25-
public static let elevationZIndex1030: ElevationRawToken = 1030
26-
public static let elevationZIndex1035: ElevationRawToken = 1035
27-
public static let elevationZIndex1038: ElevationRawToken = 1038
28-
public static let elevationZIndex1040: ElevationRawToken = 1040
29-
public static let elevationZIndex1045: ElevationRawToken = 1045
30-
public static let elevationZIndex1050: ElevationRawToken = 1050
31-
public static let elevationZIndex1060: ElevationRawToken = 1060
32-
public static let elevationZIndex1070: ElevationRawToken = 1070
33-
public static let elevationZIndex1080: ElevationRawToken = 1080
34-
public static let elevationZIndex1090: ElevationRawToken = 1090
35-
3618
// MARK: Primitive token - Elevation - X
3719

3820
public static let elevationX0: ElevationRawToken = 0
21+
public static let elevationX200: ElevationRawToken = 2
3922

4023
// MARK: Primitive token - Elevation - Y
4124

OUDS/Core/Tokens/RawTokens/Tests/ElevationRawTokensTests.swift

+6
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,12 @@ final class ElevationRawTokensTests: XCTestCase {
6262
XCTAssertTrue(radius == 6)
6363
}
6464

65+
// MARK: - Primitive token - Elevation - X
66+
67+
func testElevationXRawToken0LessThanX200() throws {
68+
XCTAssertLessThan(ElevationRawTokens.elevationX0, ElevationRawTokens.elevationX200)
69+
}
70+
6571
// MARK: - Primitive token - Elevation - Y
6672

6773
func testElevationYRawToken0LessThanY100() throws {

OUDS/Core/Tokens/SemanticTokens/Sources/TypeAliases/ElevationSemanticTokens+Aliases.swift

-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313

1414
import OUDSTokensRaw
1515

16-
/// Basically an elevation semantic token for Z Index is a raw token for elevation, with the same final type, to keep grammar clean and clear with design system grammar.
17-
public typealias ElevationZIndexSemanticToken = ElevationRawToken
18-
1916
/// Basically an elevation semantic token for X offset is a raw token for elevation, with the same final type, to keep grammar clean and clear with design system grammar.
2017
public typealias ElevationXSemanticToken = ElevationRawToken
2118

0 commit comments

Comments
 (0)