Generate junit report directory structure too (mkdir -p)

[OverkillGuy]

Problem to solve

Generating folder structure (mkdir -p) when using --report-junit flag. Identical feature to #2531, but for --report-junit after --report-html.

My previous feature request on report-html, linked, missed that the same behaviour would happen with junit reports.

As I just now upgraded to v4.3.0 with the mkdir -p feature, I "uncovered" this issue/feature request opportunity.

Proposal

Like for #2531, use create_dir_all to create all folders as needed.

Additional context and resources

Reproducing the issue

• Create a hurl file
• Run hurl --test --report-junit non-existent-folder/new_junit_file.xml
• Observe issue: error: Failed to produce JUnit report: Os { code: 2, kind: NotFound, message: "No such file or directory" }
• Run mkdir -p non-existent-folder/
• Rerun same command: hurl --test --report-junit non-existent-folder/new_junit_file.xml
• Now passes

Tracing the solution

Error message triggered here:

hurl/packages/hurl/src/report/junit/mod.rs

Line 104 in 4638705

message: format!("Failed to produce Junit report: {e:?}"),

Seems the file creation code of:

hurl/packages/hurl/src/report/junit/mod.rs

Line 93 in 4638705

let file = match File::create(filename) {

Is missing call to fs::create_dir_all?

The solution of #2531 is likely just as good

Tasks to complete

• Consensus on "do we want this?" as a tool/community (Junit is special)
• Identify a proper "fix" (previous request was just changing create_dir to create_dir_all, this may need to introduce a whole folder creation logic)

[jcamiel]

Thanks for the detailed issue @OverkillGuy the PR has been merged on master,

[OverkillGuy]

Thank you!

However the PR seems to be about TAP, not junit files? Is the code path similar somehow, or is this a similar-but-different feature implementation?
Appreciated either way

[jcamiel]

Ah ah good catch, sorry for this @OverkillGuy you're totally right 🙃. I'll update the JUnit code with the same improvement!

[jcamiel]

Hi @OverkillGuy this should be OK THIS TIME ☺️!