Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ToFloat filter #1732

Closed
claytonneal opened this issue Jul 6, 2023 · 2 comments · Fixed by #2772
Closed

add ToFloat filter #1732

claytonneal opened this issue Jul 6, 2023 · 2 comments · Fixed by #2772
Labels
enhancement New feature or request good first issue Good for newcomers topic: filters
Milestone
5.0.0

Comments

@claytonneal
Copy link

Problem to solve

When json response contains a string quoted float number, cannot use isFloat assertion

Proposal

add toFloat filter
@claytonneal claytonneal added the enhancement New feature or request label Jul 6, 2023
@jcamiel jcamiel added the good first issue Good for newcomers label Feb 15, 2024
@beaterblank
Copy link

I can take this issue very similar to previous issue I have worked on.

@chengyu2000311
Copy link
Contributor

Hey, I made a pr to add this feature #2772? BTW, I really love the idea of hurl :)

@chengyu2000311 chengyu2000311 mentioned this issue May 10, 2024
Merged
@jcamiel jcamiel added this to the 5.0.0 milestone Jun 28, 2024
@jcamiel jcamiel closed this as completed Jun 28, 2024
@jcamiel jcamiel linked a pull request Jun 28, 2024 that will close this issue
Add toFloat filter #2772
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers topic: filters
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add toFloat filter chengyu2000311/hurl
4 participants
@claytonneal @jcamiel @chengyu2000311 @beaterblank