Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hurlfmt --out html missing quotes around certificate query attributes #1515

Closed
jcamiel opened this issue May 4, 2023 · 0 comments · Fixed by #1516
Closed

hurlfmt --out html missing quotes around certificate query attributes #1515

jcamiel opened this issue May 4, 2023 · 0 comments · Fixed by #1516
Labels
bug Something isn't working
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented May 4, 2023

What is the current bug behavior?

hurlfmt --out html is missing quotes around certificate query attributes

Steps to reproduce

Given the following Hurl file:

GET https://hurl.dev
HTTP 200
[Asserts]
certificate "Subject" == "CN=hurl.dev"
certificate "Issuer" == "C=US, O=Let's Encrypt, CN=R3"
certificate "Expire-Date" daysAfterNow > 15
certificate "Serial-Number" matches "[0-9af]+"

The following command:

$ hurlfmt --out file.hurl

produces the following HTML file:

GET https://hurl.dev
HTTP 200
[Asserts]
certificate Subject == "CN=hurl.dev"
certificate Issuer == "C=US, O=Let's Encrypt, CN=R3"
certificate Expire-Date daysAfterNow > 15
certificate Serial-Number matches "[0-9af]+"

Subject, Issuer etc... have missing quotes

What is the expected correct behavior?

GET https://hurl.dev
HTTP 200
[Asserts]
certificate "Subject" == "CN=hurl.dev"
certificate "Issuer" == "C=US, O=Let's Encrypt, CN=R3"
certificate "Expire-Date" daysAfterNow > 15
certificate "Serial-Number" matches "[0-9af]+"

Execution context

  • Hurl Version (hurl --version)
hurl 3.1.0-SNAPSHOT libcurl/7.79.1 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.11 nghttp2/1.45.1
Features (libcurl):  alt-svc AsynchDNS HSTS HTTP2 IPv6 Largefile libz NTLM NTLM_WB SPNEGO SSL UnixSockets
Features (built-in): brotli
@jcamiel jcamiel added the bug Something isn't working label May 4, 2023
@jcamiel jcamiel linked a pull request May 4, 2023 that will close this issue
@jcamiel jcamiel added this to the 3.1.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant