Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transducer transform matrix should come with dims #3

Open
ebrahimebrahim opened this issue Jul 11, 2024 · 1 comment
Open

transducer transform matrix should come with dims #3

ebrahimebrahim opened this issue Jul 11, 2024 · 1 comment

Comments

@ebrahimebrahim
Copy link

In the database format / data model, the matrix for transforming a Transducer should come with "dims" just like a Point does (e.g. dims=['L','P','S']).

(Here we are talking about the transducer transform matrix that is saved to a session.json, not the (typically identity) matrix that is saved in the transducer definition)

@ebrahimebrahim
Copy link
Author

Alternative solution to this: make units and dims just be a property of Session.
From @peterhollender:

I'm working on a proposal for a new Session json format. Is it really useful to store the dims and units separately with the targets, markers (which we may be able to drop) and transducer matrix? I kind of feel like they should all be the same, and just be a property of the session, if they are stored at all. We could easily just decide that sessions are LPS or RAS and mm, and rescale anything that isn't in those coordinates on saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant