You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
There's a couple of names I think we should review.
Web3Context: This library will generally be used alongside React, where Context already has a meaning that is unrelated to how we're using the word.
web3Context.lib: The lib property on Web3Context instances holds the Web3 instance initialized with the provider. It's a very generic name. IMO, ideally the property would be web3.
useWeb3Network/fromConnection: This React hook and its corresponding factory have unrelated names, even though they are both wrappers around the same functionality.
The text was updated successfully, but these errors were encountered:
I'd love to swap Context for something more sound. Couldn't come up with anything better. Any ideas are welcome.
Regarding renaming lib for web3. The issue with web3 is that a lot of things are called web3 and having Web3Context.web3 property seems as overkill. If we rename Web3Context to something different than web3 would be more viable option.
There's a couple of names I think we should review.
Web3Context
: This library will generally be used alongside React, whereContext
already has a meaning that is unrelated to how we're using the word.web3Context.lib
: Thelib
property onWeb3Context
instances holds theWeb3
instance initialized with the provider. It's a very generic name. IMO, ideally the property would beweb3
.useWeb3Network
/fromConnection
: This React hook and its corresponding factory have unrelated names, even though they are both wrappers around the same functionality.The text was updated successfully, but these errors were encountered: