Skip to content

Refactor shouldSupportInterfaces helper #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Refactor shouldSupportInterfaces helper #5358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/utils/introspection/SupportsInterface.behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ const SIGNATURES = {
const INTERFACE_IDS = mapValues(SIGNATURES, interfaceId);

function shouldSupportInterfaces(interfaces = [], signatures = SIGNATURES) {
// case where only signatures are provided
if (!Array.isArray(interfaces)) {
interfaces = Object.keys(interfaces);
signatures = interfaces;
Comment on lines +98 to +99
Copy link
Member

@ernestognw ernestognw Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interfaces = Object.keys(interfaces);
signatures = interfaces;
signatures = interfaces;
interfaces = Object.keys(interfaces);

}

interfaces.unshift('ERC165');
signatures.ERC165 = SIGNATURES.ERC165;
const interfaceIds = mapValues(signatures, interfaceId, ([name]) => interfaces.includes(name));
Expand Down
Loading