Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UDC v2 backward compatible #1323

Open
ericnordelo opened this issue Feb 3, 2025 · 2 comments
Open

Make UDC v2 backward compatible #1323

ericnordelo opened this issue Feb 3, 2025 · 2 comments
Assignees
Milestone

Comments

@ericnordelo
Copy link
Member

ericnordelo commented Feb 3, 2025

🧐 Motivation
In the UDC v2 we introduced a couple of breaking changes to make the standard easier to follow and more gas efficient. To avoid to much friction for tooling and contracts using v1, since v2 is not adopted yet, we should consider making these changes BC.

📝 Details
We had a unique param in v1 both received in the deploy_contract function and emitted in the ContractDeployed event. This was refactored to a from_zero field, which is semantically the negation of unique (since unique was meant to signalize when the deployment is not from the zero address). This can potentially be refactored into a semantically compatible name, that is more adequate than unique, like from_not_zero

@ericnordelo ericnordelo added this to the 1. current milestone Feb 3, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Feb 3, 2025
@CaptainLEVI-XXX
Copy link
Contributor

Hey @ericnordelo , can I work on this issue ?

@ericnordelo
Copy link
Member Author

Hey @CaptainLEVI-XXX. Thanks for your interest in contributing to the library. This issue requires coordination with existing tooling and other teams, so we plan to take it ourselves. Hopefully, you can find other issues to contribute to. We have a list of good first issues that may be helpful.

@ericnordelo ericnordelo self-assigned this Feb 24, 2025
@ericnordelo ericnordelo moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants