Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting default map coordinates #345

Closed
wants to merge 3 commits into from
Closed

setting default map coordinates #345

wants to merge 3 commits into from

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented May 16, 2021 •
edited
Loading

Description

Setting the default map coordinates using the default_coordinates key in the config

Related Issue

#344

How to test it locally

  • confirm that when the map is created, the coordinates that the API sends are the default coordinates

Screenshots

Changelog

Added

Updated

  • index.js to modify config

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@emre2038 emre2038 self-assigned this May 16, 2021
@emre2038 emre2038 linked an issue May 16, 2021 that may be closed by this pull request
It's not possible to set the default map coordinates - the view reverts to the current geography #344
Open
@emre2038 emre2038 added this to the 0.14 milestone May 16, 2021
@netlify
Copy link

netlify bot commented May 16, 2021 •
edited
Loading

Deploy preview for wazimap-staging ready!

Built with commit 86b7c80

https://deploy-preview-345--wazimap-staging.netlify.app

@emre2038 emre2038 marked this pull request as ready for review May 18, 2021 08:55
@emre2038 emre2038 requested a review from milafrerichs May 18, 2021 08:55
@paulmwatson paulmwatson closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milafrerichs milafrerichs Awaiting requested review from milafrerichs

Assignees

@emre2038 emre2038

Labels
None yet
Projects
Wazimap NG
Status: Done
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

It's not possible to set the default map coordinates - the view reverts to the current geography
2 participants
@emre2038 @paulmwatson