Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving pdf output of facility modal #311

Closed
wants to merge 3 commits into from
Closed

improving pdf output of facility modal #311

wants to merge 3 commits into from

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented Apr 12, 2021

Description

fixing the issues with pdf output of the facility modal. the issues are :

  • when the facility modal has few attributes to show, the point mapper or the charts are visible on the pdf

Related Issue

#294

How to test it locally

  • on the point mapper select a category - preferably a category with few attributes so the pdf export is shorter. for example Health > Pharmacies on YE instance
  • wait until the markers are created on the map
  • click on any marker and click More Info to show the facility modal
  • open any of the side panels
  • print the page and confirm that panels are not visible on the export

Screenshots

image
image

Changelog

Added

Updated

  • css/wazimap-ng-v1.webflow.css to hide the panels when the facility modal is open
  • index.html to change the order of the divs

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for wazimap-staging ready!

Built with commit e340c86

https://deploy-preview-311--wazimap-staging.netlify.app

@emre2038 emre2038 added this to the 0.14 milestone Apr 12, 2021
@emre2038 emre2038 self-assigned this Apr 12, 2021
@emre2038 emre2038 marked this pull request as ready for review April 13, 2021 08:10
@emre2038 emre2038 requested a review from milafrerichs April 13, 2021 08:10
@@ -516,6 +516,43 @@ <h1 class="clear">Map boundary change</h1>
</div>
<div id="main-map" class="map-area"></div>
</div>
<div class="facility-info">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you switch those back. the rich data print view does not work anymore. might be related to your change here.

@paulmwatson paulmwatson closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve Point Mapper: Add a PDF download button to modal/info box/points (facility) window
3 participants