Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaying choropleth from the rich data panel #338

Closed
wants to merge 4 commits into from
Closed

displaying choropleth from the rich data panel #338

wants to merge 4 commits into from

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented May 5, 2021

Description

Displaying choropleth of a subindicator on a chart on the rich data panel

Related Issue

#281

How to test it locally

  • expand rich data panel
  • click on a Display Choropleth button on any row of any chart table
  • confirm that the rich data panel is closed and choropleth is displayed

Screenshots

a sample button that displays choropleth when clicked

image

Changelog

Added

Updated

  • profile.js, profile_loader.js, category.js, subcategory.js and indicator.js to add bubbleevent and create parents object
  • chart.js to append a temporary button to the chart tables and manage its click event
  • setup/choropleth.js to display choropleth when the button in a chart table is clicked
  • setup/miscelements.js to close rich data panel when the button in a chart table is clicked

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@emre2038 emre2038 linked an issue May 5, 2021 that may be closed by this pull request
@emre2038 emre2038 added this to the 0.14 milestone May 5, 2021
@emre2038 emre2038 self-assigned this May 5, 2021
@netlify
Copy link

netlify bot commented May 5, 2021

Deploy preview for wazimap-staging ready!

Built with commit 78c82e4

https://deploy-preview-338--wazimap-staging.netlify.app

@emre2038 emre2038 marked this pull request as ready for review May 6, 2021 21:50
@emre2038 emre2038 requested a review from milafrerichs May 6, 2021 21:50
@milafrerichs milafrerichs marked this pull request as draft May 7, 2021 09:00
@paulmwatson paulmwatson closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Map this from Rich data view - i.e move between maps/charts/tables
2 participants