Add default field to update

Author: michaelglenister

municipal_finance/management/commands/make_sub_totals.py

@@ -77,16 +77,15 @@ def handle(self, *args, **options):
                         item_code = FinancialPositionItemsV2.objects.get(code=item_key)
 
                         if sub_total != 0:
-                            try:
-                                FinancialPositionFactsV2.objects.update_or_create(
-                                    financial_year=fin_year,
-                                    financial_period=fin_year,
-                                    period_code=f"{fin_year}{amount_type_model.code}",
-                                    item_id=item_code.id,
-                                    demarcation_code=muni_code,
-                                    amount_type=amount_type_model,
-                                    period_length="year",
-                                    amount=sub_total,
-                                )
-                            except (ValueError, TypeError) as e:
-                                pass
+                            FinancialPositionFactsV2.objects.update_or_create(
+                                financial_year=fin_year,
+                                financial_period=fin_year,
+                                period_code=f"{fin_year}{amount_type_model.code}",
+                                item_id=item_code.id,
+                                demarcation_code=muni_code,
+                                amount_type=amount_type_model,
+                                period_length="year",
+                                defaults={
+                                    'amount': sub_total,
+                                }
+                            )