Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UUID with ULID #860

Closed
matrixik opened this issue Jul 1, 2021 · 4 comments
Closed

Replace UUID with ULID #860

matrixik opened this issue Jul 1, 2021 · 4 comments
Labels
enhancement New feature or request PR welcome Pull requests are welcome

Comments

@matrixik
Copy link

matrixik commented Jul 1, 2021

Is your feature request related to a problem? Please describe.
Replace UUID with ULID so exported names can be sorted lexicographically.

Describe the solution you'd like
It would fix people complains about wrong order of exported files (like #512 (comment)) and still provide unique identifier for tracks.

Describe alternatives you've considered
KSUID (more info: https://segment.com/blog/a-brief-history-of-the-uuid/). Differences to ULID: segmentio/ksuid#8.

Additional context
More explanation: https://www.honeybadger.io/blog/uuids-and-ulids/

@matrixik matrixik added the enhancement New feature or request label Jul 1, 2021
@dennisguse dennisguse added the PR welcome Pull requests are welcome label Jul 1, 2021
@dennisguse
Copy link
Member

dennisguse commented Jul 1, 2021

If those are binary compatible and solve a problem - why not.

Some things to consider:

  • Gadgetbridge also needs to be changed as they nowadays generate opentracks:trackid as well.
  • opentracks:trackid in the export/imports is required to be backward compatible

And I am (personally) not a fan of adding external dependencies to OpenTracks as it complicates long-term maintenance.
So, far we managed to just use Androidx.

@vanous
Copy link
Contributor

vanous commented Jul 11, 2021

Let us know how you decide to proceed @dennisguse , so we can follow as necessary.

@dennisguse
Copy link
Member

@vanous Not my problem - if somebody wants it, they have to built it.
Being backward compatible will be kind of painful though.
🤷‍♂️

@vanous Thanks ;)

@dennisguse
Copy link
Member

Does not seem that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome Pull requests are welcome
Projects
None yet
Development

No branches or pull requests

3 participants