Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Abnormal mandatory attachment in Collaborative Drafts #512

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Apr 2, 2024

🎩 Description

Please describe your pull request.

Removal of a useless override that we added in 0.26.7 and that is not useful as we are now in 0.27 and that the issue of a mandatory attachment came from this file.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to a proposal settings
  • Enable attachments
  • Access this proposal
  • Access to collaborative drafts
  • Create a new collaborative draft without putting any attachment
  • Check that you can create it without any error

Tasks

  • Remove file
  • Remove unused locales

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (b48acd7) to head (390d973).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #512   +/-   ##
========================================
  Coverage    89.51%   89.51%           
========================================
  Files           68       68           
  Lines         1622     1622           
========================================
  Hits          1452     1452           
  Misses         170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyakorK AyakorK marked this pull request as ready for review April 2, 2024 15:55
@AyakorK AyakorK requested review from Quentinchampenois, luciegrau and a team April 2, 2024 15:56
@luciegrau luciegrau merged commit bd14241 into develop Apr 3, 2024
16 checks passed
@luciegrau luciegrau deleted the fix/abnormal_mandatory_attachment branch April 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants