Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add email & name in proposals and surveys exports #510

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Mar 7, 2024

🎩 Description

Please describe your pull request.

  • Lock wicked_pdf to 2.6.3 and add dedicated spec
  • Ensure user email & name are exported only for registered answers
  • Ensure author email & name are exported for proposals admin exports

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin

  • Access Backoffice

  • Export proposals

  • Export surveys

  • As a visitor

  • Export open data

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (7bc1f00) to head (4f72c84).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
+ Coverage    89.43%   89.51%   +0.08%     
===========================================
  Files           67       68       +1     
  Lines         1609     1622      +13     
===========================================
+ Hits          1439     1452      +13     
  Misses         170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review March 8, 2024 09:20
@Quentinchampenois Quentinchampenois changed the title Feat/backport email in exports feat: Add email & name in proposals and surveys exports Mar 8, 2024
@Quentinchampenois Quentinchampenois requested review from luciegrau, AyakorK and a team March 8, 2024 09:24
@luciegrau luciegrau merged commit b48acd7 into develop Mar 11, 2024
16 checks passed
luciegrau added a commit that referenced this pull request Mar 11, 2024
@luciegrau luciegrau deleted the feat/backport_email_in_exports branch March 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an email column to proposal and form answers exports
3 participants