Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport language selector and allow to modify notification sending frequency #505

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Mar 5, 2024

🎩 Description

Please describe your pull request.

When there is only one locale in organization, disable dropdown in user account form. Otherwise displays a dropdown

Also sysadmin can modify default notifications_sending_frequency using env var NOTIFICATIONS_SENDING_FREQUENCY = "daily", "weekly", "none", "real_time" through module extra-user-fields

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (7bc1f00) to head (565ceb2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #505   +/-   ##
========================================
  Coverage    89.43%   89.43%           
========================================
  Files           67       67           
  Lines         1609     1609           
========================================
  Hits          1439     1439           
  Misses         170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review March 7, 2024 13:48
@Quentinchampenois Quentinchampenois changed the title feat: Backport language selector feat: Backport language selector and allow to modify notification sending frequency Mar 7, 2024
@Quentinchampenois Quentinchampenois requested review from luciegrau and a team March 7, 2024 13:53
@luciegrau luciegrau merged commit b67b452 into develop Mar 8, 2024
16 checks passed
@luciegrau luciegrau deleted the feat/backport_language_selector branch March 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants