Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable session store with ActiveRecord #472

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Quentinchampenois
Copy link
Contributor

🎩 Description

Please describe your pull request.

When user creates an initiative, and body is heavy, it raises a ActionDispatch::Cookies::CookieOverflow error.

This PR add the possibility to configure ActiveRecord SessionStore using env var RAILS_SESSION_STORE

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Run rails server with ActiveRecord env var : RAILS_SESSION_STORE=active_record bundle exec rails s
  • Create initiative with large body
  • See no error

Tasks

  • Add reversible migration
  • Allow to switch the session store

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7182e42) 89.37% compared to head (898b07e) 65.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #472       +/-   ##
============================================
- Coverage    89.37%   65.93%   -23.44%     
============================================
  Files           64       58        -6     
  Lines         1581     1547       -34     
============================================
- Hits          1413     1020      -393     
- Misses         168      527      +359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review January 9, 2024 16:58
Copy link
Collaborator

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great, thank you! 😄

@luciegrau luciegrau requested review from a team and removed request for a team January 11, 2024 16:26
@moustachu moustachu merged commit 052c5d5 into develop Jan 11, 2024
15 of 16 checks passed
@Quentinchampenois Quentinchampenois deleted the feat/activerecord_session_store branch April 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants