Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Backport fix of disappearance of iframes #451

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: Backport fix of disappearance of iframes #451

merged 1 commit into from
Oct 23, 2023

Conversation

AyakorK
Copy link
Contributor

@AyakorK AyakorK commented Oct 20, 2023

🎩 Description

We backport CD44 - #146 to fix the disappearance of Iframes

Testing

Describe the best way to test or validate your PR.

Example:

  • Log in as admin
  • Access Backoffice
  • Go to participatory processes
  • Choose the first one
  • Add an iframe to the description of it
  • Go to the page linked
  • Check if iframe appears

Tasks

  • Add specs
  • Extend the file that disables iframes

@AyakorK AyakorK marked this pull request as ready for review October 23, 2023 08:27
@AyakorK AyakorK marked this pull request as draft October 23, 2023 09:05
@AyakorK AyakorK marked this pull request as ready for review October 23, 2023 09:43
luciegrau
luciegrau approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you!

@Quentinchampenois Quentinchampenois merged commit 8462b84 into develop Oct 23, 2023
16 checks passed
@Quentinchampenois Quentinchampenois deleted the fix/iframe_disappearance branch October 23, 2023 15:51
@moustachu moustachu added this to the v2.0.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentinchampenois Quentinchampenois Awaiting requested review from Quentinchampenois

@luciegrau luciegrau Awaiting requested review from luciegrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AyakorK @Quentinchampenois @luciegrau @moustachu