feat: Configure Puma server and Local docker-compose with HTTPS #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #445 +/- ##
============================================
- Coverage 77.59% 61.97% -15.63%
============================================
Files 61 51 -10
Lines 1616 1336 -280
============================================
- Hits 1254 828 -426
- Misses 362 508 +146 ☔ View full report in Codecov by Sentry. |
Quentinchampenois
force-pushed
the
feat/docker-compose-local
branch
from
3e01bf8
to
74caad9
Compare
Quentinchampenois
requested review from
luciegrau,
a team and
AyakorK
and removed request for
a team
|
Backport fixes from decidim-lyon |
Quentinchampenois
changed the title
fix typo
moustachu
pushed a commit
that referenced
this pull request
Mar 6, 2024
* feat: Local docker-compose * fix: Update make run command * fix: Local docker-compose * fix: Webpacker compilation * fix: Local docker-compose * fix: Docker-compose with https in local * doc: Add Getting started with Docker in README * fix: Add letter_opener gem to global scope * feat: Add docker commands to Makefile * fix: backport fix docker-compose * refactor: Remove not needed entrypoint.local.sh * feat: Generate SSL certificate in Dockerfile.local * fix: Fine tuning puma on docker-compose local * lint: Fix rubocop offense * Update GETTING_STARTED_DOCKER.md fix typo --------- Co-authored-by: ailepet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Description
Please describe your pull request.
This PR adds a new docker-compose specific for localhost. It is similar to the current
docker-compose.ymlbut it is based onDockerfile.localwhich runs application on SSL using self signed certificateAlso it allows to configure Puma webserver according to recommandations :
"Worker counts should be somewhere between 4 and 32 in most cases. You want more than 4 in order to minimize time spent in request queueing for a free Puma worker, but probably less than ~32 because otherwise autoscaling is working in too large of an increment or they probably won't fit very well into your nodes"
Testing
Describe the best way to test or validate your PR.
make runTasks
Environment variables
PUMA_WORKERSInteger (def: -1) - if positive, set multi process on PumaPUMA_MIN_THREADSInteger (def: 5) - Set number of minimum puma threadsPUMA_MAX_THREADSInteger (def: 5) - Set number of maximum puma threadsPUMA_PRELOAD_APPString/Bool (def: "false") - if "true" preloads app in Puma