Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initiatives gem to 0.27 branch #418

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

paulinebessoles
Copy link
Contributor

@paulinebessoles paulinebessoles commented Aug 25, 2023

🎩 Description

This PR adds the intiative gem and its migrations.

📌 Related Issues

No related issue

Testing

Check that the initiatives are enabled on the admin dashboard.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.98% ⚠️

Comparison is base (eb4b189) 77.17% compared to head (5d04952) 70.19%.

Additional details and impacted files
@@              Coverage Diff              @@
##           bump_0.27     #418      +/-   ##
=============================================
- Coverage      77.17%   70.19%   -6.98%     
=============================================
  Files             58       48      -10     
  Lines           1555     1275     -280     
=============================================
- Hits            1200      895     -305     
- Misses           355      380      +25     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulinebessoles paulinebessoles marked this pull request as ready for review August 25, 2023 09:24
@armandfardeau
Copy link
Collaborator

Hello thanks for your contribution !

However:

  • the P.R. description is empty, please help us generate release note by adding it.
  • The CI fails, please wait until the original branch is fixed then rebase.
  • Your P.R. title is missing a descriptive feat:, fix: to generate release note

I've switched this P.R. to draft, feel free to request a review when everything is in order

@armandfardeau armandfardeau marked this pull request as draft August 25, 2023 09:27
@paulinebessoles paulinebessoles changed the title Add initiatives gem to 0.27 branch feat: Add initiatives gem to 0.27 branch Aug 25, 2023
@armandfardeau armandfardeau marked this pull request as ready for review August 28, 2023 13:36
@armandfardeau armandfardeau merged commit 878e8d0 into bump_0.27 Aug 28, 2023
12 checks passed
@armandfardeau armandfardeau deleted the add/initiatives_0.27 branch August 28, 2023 14:15
@moustachu moustachu added this to the v2.0.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants