Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hit_point and trace_depth to reflections #825

Open
ClemensLinnhoff opened this issue Jul 2, 2024 · 0 comments
Open

Add hit_point and trace_depth to reflections #825

ClemensLinnhoff opened this issue Jul 2, 2024 · 0 comments
Assignees

Comments

@ClemensLinnhoff
Copy link
Contributor

Describe the feature

Currently it is not possible to get hit_point information for individual ray tracing results (reflections). You can get the first hit_point with the ray direction (from the view_configuration) and the time_of_flight. But if the there are multiple reflections per ray (by reflection and transmission) it is not possible to get the hit point information.

Describe the solution you would like

I would like to add as Vector3D hit_point and an Integer trace_depth to the LidarSensorView::reflection and the RadarSensorView::reflection.

Describe alternatives you have considered

An alternative would be to put the hit_points in a separate structure and not into the reflections. But since the general structure is similar, it should not be a problem to add them. Just the following backwards compatibility deliberations need to be discussed.

Describe the backwards compatibility

There is a potential problem with the description of the reflection field:

This field includes one entry for each ray, in left-to-right, top-to-bottom order (think of scan lines in a TV).

If there are multiple reflections per ray, the size of the repeated field would be num_rays * max_trace_depth. So there is not one entry per ray. On the other hand, the max_number_of_interactions can already be set in the view_configuration.

Additional context

To be honest, for me this is more of a debugging feature, which technically is out of scope for OSI. But I can still see potential applications for models needing a more in depth access to ray tracing data.

@ClemensLinnhoff ClemensLinnhoff self-assigned this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant