Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrafficLight rework proposal. #754

Open
brianr1234 opened this issue Jan 9, 2024 · 0 comments
Open

TrafficLight rework proposal. #754

brianr1234 opened this issue Jan 9, 2024 · 0 comments

Comments

@brianr1234
Copy link

Describe the feature

Problem to be solved:
When using the OSI TrafficLight message its not possible to recreate the full dimensions of a traffic light object from just the bulbs, additionally all bulbs in a GroundTruth message must be parsed and combined to retrieve the information for a single traffic light.

By creating a full traffic light class and storing the bulb information inside it would make the data easier to parse and allow for full traffic light dimensions to be sent.

Describe the solution you would like

I would like to see current TrafficLight object renamed to be TrafficLightBulb and the creation of two new classes:

  • TrafficLightHousing
  • TrafficLight

TrafficLightHousing would contain an OSI ID, dimensions, position, orientation, color. (Could be a StationaryObject if TYPE_TRAFFIC_LIGHT_HOUSING were added to the classifications)

TrafficLight (which would remain the object sent via GroundTruth) would contain an OSI ID, TrafficLightHousing, one or more TrafficLightBulbs and optionally the ID of any objects it is attached to eg a static object like a pole.

Describe the backwards compatibility

Due to the naming change this would be a major new version of the OSI standard, it would break TrafficLight backwards compatibility with older versions due to prior naming choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant