Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit and rules from osi3::LidarDetection::intensity #745

Open
ClemensLinnhoff opened this issue Nov 27, 2023 · 0 comments
Open

Remove unit and rules from osi3::LidarDetection::intensity #745

ClemensLinnhoff opened this issue Nov 27, 2023 · 0 comments

Comments

@ClemensLinnhoff
Copy link
Contributor

Describe the feature

Currently, the field osi3::LidarDetection::intensity has the unit % and per the defined rules can have values between 0 and 100 (which makes sense for %). However, real lidar sensors have a variety of different intensity definitions.

I my opinion, the intensity output of a sensor model should be in the same unit and scale as in the corresponding real sensor.
Therefore, I propose to remove the unit specification and the value rules.

Describe alternatives you have considered

The alternative now is to scale the intensity in the subsequent logical model. However, intensity scaling should be part of the sensor model and not a logical model.

Describe the backwards compatibility

The intensity value is already a double. So there should be no issue. Only the documentation would be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant