Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versionless feature impact on Liberty maven and gradle plugins #26703

Open
cbridgha opened this issue Oct 24, 2023 · 2 comments
Open

Versionless feature impact on Liberty maven and gradle plugins #26703

cbridgha opened this issue Oct 24, 2023 · 2 comments

Comments

@cbridgha
Copy link
Member

cbridgha commented Oct 24, 2023

Version-less features being proposed in Epic #25704 describe defining features by their function only without specifying a version.

The Liberty plugins have similar feature install "goals" as the featureUtility.

Similar to installFeature, which lists features to be installed, or installServerFeatures, which uses the features listed in the server.xml.

installServerFeatures will be the only "supported command for versionless.

installFeature <versionless feature> is not supported, and should fail stating installing versionless features is not supported.

installFeature "goal" is documented here

Maven goals are backed by "Mojo" classes that provide the logic, and call into feature install api's.

The InstallFeatureMojo and InstallServerMojo are where most of this logic appears.

@cherylking
Copy link
Member

installServerFeatures will be the only "supported command for versionless.

installFeature is not supported, and should fail stating installing versionless features is not supported.

I think this is a problem since the plugins support both. When we get the list of features to install, we combine whatever is in the server.xml and what is configured in the pom.xml I believe and pass the whole list to the Liberty InstallMap.

@jjiwooLim is the expert on this though and how it works in the plugins.

@jjiwooLim
Copy link
Contributor

jjiwooLim commented Aug 16, 2024

Plugins actually only supports installServerFeatures because as per design, it only targets one server at a time. This is the PR that changed it. There's a short period where we supported both installServerFeatures and installFeature (liberty 21.0.0.7+ and plugins before this PR released) but I don't think that was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes after GA
Development

No branches or pull requests

3 participants