Windows: Dev mode can crash when editing server.xml with a java.lang.NoClassDefFoundError. #429
Comments
mrglavas
changed the title
mrglavas
changed the title
|
I just tried this on my VSCode install in Mac. 
I did not get any exception.
|
|
Attempted to reproduce with IntelliJ on Windows environment. Got a different, but valid exception and dev mode is still running: |
|
Since the error is on I checked the behavior of the Liberty Maven plugin and dev mode outside of Liberty Tools on Mac and found the following:
The server shutdown works fine when I press Opened issue 1682 in LMP to modify that behavior slightly to improve user experience. |
|
On MAC the issue does not occur.
|
|
I just tested this using Eclipse in Windows - and I was able to recreate. 
|
|
Retried this in Windows Eclipse using the -X -e option using "Start ..." Here's the stack trace of the exception. |
|
Noting here that I put two fixes into ci.common and produced a I also opened an issue in LCLS to revisit whether we should flag a diagnostic for an empty feature element. |
|
Wondering if this can be recreated with a non-existing feature like "bogus-1.0" instead of an empty feature? The fixes I made in LMP/LGP would have no affect on that scenario. |
|
@cherylking After updating to: I can still get dev mode to crash by specifying any feature (e.g. "mpOpenAPI-3.1"), not just a non-existing one like "bogus-1.0". Also noticed a slight difference in the output between 3.7.1 and 3.8.1. When the 3.7.1 process exits, it says the build failed. When the 3.8.1 process exits, it says the build succeeded despite dev mode actually crashing. It prints similar stack traces at the end in both cases. Maven plugin 3.7.1 output: Maven plugin 3.8.1 output: |
|
@mrglavas You are saying if you add a valid feature to server.xml and save while dev mode is running, it crashes? And this is only with the latest |
|
@cherylking Adding a valid feature to server.xml and saving it crashes for both |
@mrglavas Wondering if you could recreate this outside of the IDE with just a command prompt running |
|
@cherylking I ran
|
ok, good to know. Thanks for trying that. This is obviously an issue with the plugins and not Liberty Tools. We will get an issue open and follow up. |
|
fyi..I am working on some changes in ci.common to hopefully avoid this exception path. I will update here when a Liberty Maven plugin |
|
Looking at this list of messaging related features to find the ones that need to be installed to trigger this issue... ...the only two that lead to exceptions when a new feature is added are Note: the initial list may not be an exhaustive list of messaging features. |
|
I published a You need to have the following in the pom.xml to use snapshots: Updated with correct pom.xml configuration. |
|
The fix in the |
|
Can we mark this as resolved by the changes that went into ci.common in this PR? I have already published ci.common |
|
I do have these 2 features in my server.xml After going to lmp 3.8.1, I was unable to reproduce using the empty feature . Switching to lmp 3.8.2-SNAPSHOT does resolve this probelm. |
|
|
|
The Liberty Maven plugin |
Steps to reproduce:
Received the following exception in the terminal before the process died.
I had to manually stop Liberty with
mvn liberty:stopbefore I could start dev mode again. I tried this again and got the same result so it seems to be reproducible.The text was updated successfully, but these errors were encountered: