-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP4Jakarta quick fixes not appearing (e.g. for @WebServlet annotation attributes ) #377
Comments
One clue here in preparing LTE v23.0.9 on top of v4.28. We tried removing the jdt.ls dependency altogether since it is only needed by the LTE LSP4MP client (the LSP4Jakarta path provides the "JDTUtils" function from a copy shipped within LSP4Jakarta). When we removed the jdt.ls bundle, this problem went away. Would it help to, in the debugger, add breakpoints to the JDT LS function related to the code action path, and see how it might be getting in the way? |
interestingly enough... I tried doing like Quarkus kinda did, telling LSP4MP we were using our own JDTUtils so as not to require the jdt.ls bundle again... and for "our own" I mostly delegated to the LSP4Jakarta one. So.. it basically seemed to "work" ... the MP function was back. Two things I didn't implement: fetching source and fetching Javadoc..the latter looked like a bigger deal but haven't noticed where it surfaces yet. However, the QF problem is back ! It's not fixed even without the jdt.ls bundle (ie removing that). One might interpret that as something like.. it's the combination of LSP4Jakarta and LSP4MP each doing their own QF stuff that is the problem... rather than the code in jdt.ls specifically interacting with our LTE LSP4E code. |
Workaround seems to be to ensure the MP OpenAPI dep is not on the path... e.g.: <dependency>
<groupId>org.eclipse.microprofile</groupId>
<artifactId>microprofile</artifactId>
<version>6.0</version>
<type>pom</type>
<scope>provided</scope>
<exclusions>
<exclusion>
<groupId>org.eclipse.microprofile.openapi</groupId>
<artifactId>microprofile-openapi-api</artifactId>
</exclusion>
</exclusions>
</dependency> |
With LTE 0.9.0 on Eclipse v4.27 Enterprise Java,
When using an empty
@WebServlet
annotation I see the diagnostic message:The annotation @WebServlet must define the attribute 'urlPatterns' or 'value'.
but the only quick fix I see is for generating OpenAPI annotations.The text was updated successfully, but these errors were encountered: