Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle feature names that changed #300

Closed
cherylking opened this issue Aug 29, 2024 · 5 comments · Fixed by #305
Closed

Handle feature names that changed #300

cherylking opened this issue Aug 29, 2024 · 5 comments · Fixed by #305
Assignees

Comments

@cherylking
Copy link
Member

cherylking commented Aug 29, 2024

There are features where the name has changed (e.g. jsp-2.3 changed to pages-3.0, ejb-3.2 changed to enterprisebeans-4.0). This affects checks that we currently do with versioned features and maybe versionless features. A hard-coded map has been added in the code here. We need to make use of this when checking for diagnostics related to features.

  • multiple versions of a feature - if jsp-2.3 and pages-3.0 are both specified, flag that as an error
  • we should flag an error if both jsp and pages are specified
  • we should flag an error if jsp and pages-3.0 are specified
  • any combination of versioned and versionless features that in essence means multiple of the same feature/technology are configured should flag an error diagnostic

Check to see if any of our quick fix suggestions should be modified also.

@cherylking
Copy link
Member Author

cherylking commented Sep 27, 2024

Suggested wording from Liberty dev:

ERROR: The x feature cannot be configured with the y feature because they are two different versions of the same technology. Remove one of the features.

Further feedback suggests we should not use "technology" in the message. Message is still being worked on.

@cherylking
Copy link
Member Author

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

@arunvenmany-ibm
Copy link
Contributor

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

is all the featurename changes are for jakarta ee ? Otherwise we may need to customize message for different versions of microprofile as well,

@cherylking
Copy link
Member Author

ERROR: The jsp-2.3 feature cannot be configured with the pages-3.0 feature because they are different versions of the same feature. The feature name changed from jsp to pages for Jakarta EE. Remove one of the features.

is all the featurename changes are for jakarta ee ? Otherwise we may need to customize message for different versions of microprofile as well,

Yes, all are for Jakarta EE.

@cherylking
Copy link
Member Author

cherylking commented Sep 27, 2024

If something comes up in the future unrelated to Jakarta EE, we can handle it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants