Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider all features enabled by Liberty configuration files for diagnostic checks #230

Open
cherylking opened this issue Oct 12, 2023 · 3 comments
Labels
enhancement New feature or request LemMinX Liberty extension to Eclipse Lemminx

Comments

@cherylking
Copy link
Member

Follow on to issue #67. The diagnostic code for config elements that do not have a feature configured only takes into account the features listed in the current xml file. If other xml files are included via the <include> element, or by placing them in the configDropins folder, any features listed in those xml files are not considered in the diagnostic check.

@cherylking cherylking added the enhancement New feature or request label Oct 12, 2023
@cherylking
Copy link
Member Author

This also means that config snippets in configDropins will show diagnostics even though the feature is configured in the xml file that includes it.

@cherylking
Copy link
Member Author

Good reference doc for Liberty config and include file processing.

@cherylking
Copy link
Member Author

Decided to put this one on pause until we get customer feedback.

@evie-lau evie-lau added the LemMinX Liberty extension to Eclipse Lemminx label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LemMinX Liberty extension to Eclipse Lemminx
Projects
None yet
Development

No branches or pull requests

2 participants