Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature auto-complete should exclude different versions of already included features. #161

Open
jvanhill opened this issue Feb 3, 2023 · 2 comments
Labels
enhancement New feature or request LemMinX Liberty extension to Eclipse Lemminx

Comments

@jvanhill
Copy link

jvanhill commented Feb 3, 2023

The feature auto-complete for server.xml should exclude features that are a different version of the a feature that is already included. For example, if servlet-3.1 is included, servlet-4.0 and servlet-5.0 should not be included in the auto-complete options.

Additionally, it would be good if the user included a feature that is specific to an EE version, that features that don't support that EE version were excluded as well. That would probably need to be another issue (and may be too complex to determine from the tools).

@cherylking
Copy link
Member

@jvanhill Thank you for the feedback. Initially I thought your first suggestion made complete sense. But what if they decided they needed to change which version of a feature they wanted to use? They would no longer be able to see all the versions available. Perhaps we just need a diagnostic if they specify multiple feature elements with different versions (e.g. they have both servlet-4.0 and servlet-5.0 in their feature section). What do you think?

As for the second suggestion, I don't believe we have data available at the language server level that would tell us which features are for which EE version.

@evie-lau evie-lau added enhancement New feature or request LemMinX Liberty extension to Eclipse Lemminx labels Feb 21, 2023
@cherylking
Copy link
Member

Just wanted to note here that with this PR additional info is displayed for features, including what features enable the feature as well as what features are enabled by the feature. This can sometimes shed some light on which EE version a feature is part of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LemMinX Liberty extension to Eclipse Lemminx
Projects
None yet
Development

No branches or pull requests

3 participants