Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMP 3.10.2 liberty:run/dev goal skipped using spring-boot and JAR packaging type #1809

Closed
gkwan-ibm opened this issue Apr 10, 2024 · 6 comments

Comments

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Apr 10, 2024

Reported by an user at OpenLiberty/guide-spring-boot#157

./mvnw liberty:run does not start and return following:

[INFO] --- liberty-maven-plugin:3.10.2:run (default-cli) @ guide-spring-boot ---
[INFO] 
Skipping module guide-spring-boot which is not included in this invocation of the run goal.

If using liberty-maven-plugin:3.10, liberty:run works fine

Steps to reproduce the problem:

  • git clone https://github.com/openliberty/guide-spring-boot.git
  • cd guide-spring-boot/finish
  • ./mvnw package
  • ./mvnw liberty:run
  • return the above Skipping ... message
  • update the pom.xml to use LMP 3.10
  • ./mvnw liberty:run
  • liberty can be started successfully
@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented Apr 10, 2024

temporarily fixed the spring-boot guide by downgrading to LMP 3.10

Revised steps to reproduce the problem:

  • git clone https://github.com/openliberty/guide-spring-boot.git
  • cd guide-spring-boot/finish
  • update the pom.xml to use LMP 3.10.2
  • ./mvnw package
  • ./mvnw liberty:run
  • return the above Skipping ... message

@scottkurz
Copy link
Member

I assume this must have been caused by:
#1800

@cherylking
Copy link
Member

@scottkurz I presume so as well. Need a special check for spring-boot case?

@scottkurz scottkurz changed the title LMP 3.10.2 liberty:run goal does not work with spring-boot LMP 3.10.2 liberty:run/dev goal skipped using spring-boot and JAR packaging type Apr 10, 2024
@cherylking
Copy link
Member

Fixed via PR #1810

@gkwan-ibm Would you like a snapshot driver to test with?

@gkwan-ibm
Copy link
Member Author

if there is a snapshot, I can test it. Otherwise, I can test it when the fix is released.

@cherylking
Copy link
Member

This fix is included in the 3.10.3 release published yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants