Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changes needed to handle new possibility of server config <include> elements pointing to a directory #1720

Closed
cherylking opened this issue Aug 23, 2023 · 3 comments · Fixed by OpenLiberty/ci.common#425

Comments

@cherylking
Copy link
Member

This OpenLiberty issue adds support for the <include> element location attribute to point to a directory containing server config files. This will affect any plugin code that processes the server.xml <include> elements.

At a minimum, I know it affects feature element processing, and how we look for inclusion of applications.

@cherylking
Copy link
Member Author

This would affect Liberty Gradle plugin also.

@cherylking
Copy link
Member Author

The OL issue is currently targeted for 23.0.0.10 which has an eGA of 10/17. It is also planned to be included in the 23.0.0.10-beta which has an eGA of 9/19.

@cherylking
Copy link
Member Author

Pointers to some affected classes:

  • ServerConfigDocument in ci.common (parseIncludeVariables, parseInclude)
  • ServerFeatureUtil in ci.common (parseIncludeNode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants