Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional conditions for resolving variables #126

Open
cherylking opened this issue Jan 30, 2020 · 1 comment
Open

Handle additional conditions for resolving variables #126

cherylking opened this issue Jan 30, 2020 · 1 comment
Assignees

Comments

@cherylking
Copy link
Member

cherylking commented Jan 30, 2020

In ServerConfigDocument, there is logic that resolves variables referenced by server.xml for the application location and name. This logic processes all the config files that Liberty looks in, but does not look at system properties or environment variables. The document here (https://openliberty.io/docs/ref/config/) indicates those should be used. In a build environment, perhaps that does not make sense. But we should look into it and ensure this behavior is intentional.

That document also covers additional syntax for resolving variable references that we are not handling. We should add logic for this. Here is an excerpt:

Replace all non-alpha num characters with _

Change all characters to upper case.

If you enter ${my.env.var} in server.xml it will look for environment variables with the following names:

my.env.var

my_env_var

MY_ENV_VAR

@dshimo dshimo self-assigned this Nov 7, 2023
@cherylking
Copy link
Member Author

This part of the Liberty doc is also new since this code was last updated. Need to handle this as well.

Screenshot 2023-11-07 at 1 44 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Target fix release
Development

No branches or pull requests

2 participants