Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI: Firmware Tab, manufacturers not loading #89

Open
2 tasks done
mikecarr opened this issue Feb 22, 2025 · 0 comments
Open
2 tasks done

[Bug]: UI: Firmware Tab, manufacturers not loading #89

mikecarr opened this issue Feb 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mikecarr
Copy link
Member

Requirements

  • I checked the troubleshooting section in the README to verify that I have the latest Configurator version.
  • I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior

When a user selects the Connect button, the apps makes a call to Github api to download the builder list in json, it then uses this to parse and populate the dropdown in the Firmware upgrade tab. If a user connects to often we get a rate limit error.

System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (rate limit exceeded).

The results from this call should be cached so it does not break the limit

https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#primary-rate-limit-for-unauthenticated-users

Expected Behavior

No response

Steps To Reproduce

No response

Context

YAML state

Environment

- Config Version:

Anything else?

No response

@mikecarr mikecarr added the bug Something isn't working label Feb 22, 2025
@mikecarr mikecarr changed the title [Bug]: Firmware not loading [Bug]: UI: Firmware Tab, manufacturers not loading Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant