Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non breaking space (NBSP) in spreadsheet headers #392

Open
odscjames opened this issue Nov 24, 2021 · 2 comments
Open

Non breaking space (NBSP) in spreadsheet headers #392

odscjames opened this issue Nov 24, 2021 · 2 comments

Comments

@odscjames
Copy link
Contributor

We have seen cases where Excel spreadsheets have header columns like:

Recipient Org:Location:Name

Where the space there is actually a non breaking space (NBSP).

When using flattentool by passing an Excel spreadsheet and a schema this causes issues. In the schema the name "Recipient Org" has a normal space, and so flattentool doesn't recognise that header as being one of the core fields in the standard. Instead it thinks it's an additional field.

Found when doing ThreeSixtyGiving/dataquality#14

@odscjames
Copy link
Contributor Author

Can we just search and replace "NBSP" to " " [ a real space ] before looking up column titles in the schema?

Maybe in both:

  • the title being looked up?
  • the titles in the schema (in case someone ever uses a NBSP in a schema title?)

Is there any case where someone might actually deliberately be using the difference between NBSP's and real spaces in schema field titles as an important thing?

(If there is, do we really want to be encouraging that?!)

@robredpath
Copy link
Member

robredpath commented Nov 25, 2021

Do we have any theories as to how an NBSP got in there in the first place?

I've checked the 360 standard and the spaces in the table there are real spaces, so it's not a copy-paste error there. I tried emailing it, and (at least our email) doesn't make it an NBSP even though it's an HTML email.

Was there a Recipient Org:Location:Identifier field? I'd expect that to come first, so the fact that it errored on Name is interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants