You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think there's anything technically wrong here, but I think this is harder to read/maintain/verify than it should be. In OpenDDS/rosidl_typesupport_opendds#18 some types were changed from void* to their actual DDS API types, but these were not. I think we should do a follow-on PR in that repo to make this more consistent.
I don't think there's anything technically wrong here, but I think this is harder to read/maintain/verify than it should be. In OpenDDS/rosidl_typesupport_opendds#18 some types were changed from
void*
to their actual DDS API types, but these were not. I think we should do a follow-on PR in that repo to make this more consistent.Originally posted by @mitza-oci in https://github.com/oci-labs/rmw_opendds/diffs/4
The text was updated successfully, but these errors were encountered: