Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use actual DDS API types when possible #30

Open
adamsj-ros opened this issue May 15, 2020 · 0 comments
Open

use actual DDS API types when possible #30

adamsj-ros opened this issue May 15, 2020 · 0 comments

Comments

@adamsj-ros
Copy link
Contributor

I don't think there's anything technically wrong here, but I think this is harder to read/maintain/verify than it should be. In OpenDDS/rosidl_typesupport_opendds#18 some types were changed from void* to their actual DDS API types, but these were not. I think we should do a follow-on PR in that repo to make this more consistent.

Originally posted by @mitza-oci in https://github.com/oci-labs/rmw_opendds/diffs/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant