-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use entitlements for activation routes #494
Comments
|
There could be other entitlement values set. I wouldn't call these "invalid". Entitlement values that do not match the configured ones must not have any effect. (Pieter van der Meulen - Oct 30, 2024) |
I meant invalid in the context of this story, but fair enough. (bstrooband - Oct 30, 2024) |
There are rules for when a user is allowed self-service registration. E.g. if a user once had a token, they are no longer allowed to self-register. See the registration flows: https://www.plantuml.com/plantuml/proxy?src=https://raw.githubusercontent.com/wiki/OpenConext/Stepup-Deploy/ApplicationFlows/SS-2ndfactor.plantuml This remark is meant as a catch-all. If the entitlements only allow one route, e.g. self-service registration, but this registration option is not allowed by the registration rules, then a user may not have any options to register and would be stuck. This is not something that we want, so if such a situation occurs, ignore the entitlements and show all the options that are allowed by the registration flow. The registration flow is designed such that there is always a way out for the user. (Pieter van der Meulen - Oct 30, 2024) |
OpenConext/Stepup-SelfService#336 (review) (bstrooband - Nov 4, 2024) |
Makes sense and should be easy to implement. Add an option to configure this in the same place as where the entitelement values are configured, default to urn:mace:dir:attribute-def:eduPersonEntitlement. (Pieter van der Meulen - Nov 4, 2024) |
This issue is imported from pivotal - Originaly created at Jul 7, 2023 by Pieter van der Meulen
We recognize two string values for eduPersonEntitlementEntitlement, their actual values must be configurable in the SS configuration. E.g.:
urn:mace:surf.nl:surfsecureid:activation:self
urn:mace:surf.nl:surfsecureid:activation:ra
(Let's use the same names and values as the config parameters for
preferred_activation_flow_name
andpreferred_activation_flow_options
)If the
self
entitlement is present, the user is only allowed to self-activate his tokenIf the
ra
entitlement is present, the user is only allowed to visit the servicedesk for token activationIf both or non of the entitlements are present, both activation routes are allowed.
The query-parameter-hints (i.e.
https://selfservice/?activate=ra
andhttps://selfservice/?activate=self
) from see: https://www.pivotaltracker.com/n/projects/1163646/stories/181966790 must still be taken into account when none or both entitlements are present, but the entitlements overrule the query-parameter hint.If applying the constraints from entitlement would result in no options being available for a user, act as if no entitlements are set. This can happen when a user already has a vetted token, but they only have the
urn:mace:surf.nl:surfsecureid:activation:self
entitlement.eduPersonEntitlement is a multi-valued attribute an my contain other entitlement values besides those configured for
self
andra
. These other entitlement values must be ignored by the application.The text was updated successfully, but these errors were encountered: