Create Gateway Institution Configuration projection row if not exists #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Gateway institution configuration is updated because the sso on 2fa config changed for that institution. The projection would only be updated if the institution already exists in the projection. If the projection did not yet have the institution, then the projection was not updated. This fix now creates the row if the projection is not yet present.
MKodde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Gateway institution configuration is updated because the sso on 2fa config changed for that institution. The projection would only be updated if the institution already exists in the projection. If the projection did not yet have the institution, then the projection was not updated.
This fix now creates the row if the projection is not yet present. This only works now that we only track one single configuration value.
Note that the real solution to this problem would be to do an event replay. But to prevent an event replay on
prodwe choose to add this construction.https://www.pivotaltracker.com/story/show/185833305