Skip to content

Commit 7cb32fa

Browse files
author
Alex Rothuis
committed
Boyscout: correct dataprovider naming and data
1 parent d95fa14 commit 7cb32fa

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/Surfnet/Stepup/Tests/Configuration/Value/LocationTest.php

+8-6
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ class LocationTest extends UnitTest
2626
/**
2727
* @test
2828
* @group domain
29-
* @dataProvider nonStringOrEmptyStringProvider
29+
* @dataProvider nonStringProvider
3030
* @expectedException \Surfnet\Stepup\Exception\InvalidArgumentException
3131
*
32-
* @param mixed $nonStringOrEmptyString
32+
* @param mixed $nonString
3333
*/
34-
public function it_cannot_be_created_with_anything_but_a_nonempty_string($nonStringOrEmptyString)
34+
public function it_cannot_be_created_with_anything_but_a_string($nonString)
3535
{
36-
new Location($nonStringOrEmptyString);
36+
new Location($nonString);
3737
}
3838

3939
/**
@@ -55,13 +55,15 @@ public function two_locations_with_the_same_value_are_equal()
5555
/**
5656
* dataprovider
5757
*/
58-
public function nonStringOrEmptyStringProvider()
58+
public function nonStringProvider()
5959
{
6060
return [
61+
'null' => [null],
62+
'boolean' => [false],
6163
'array' => [[]],
6264
'integer' => [1],
6365
'float' => [1.2],
64-
'object' => [new \StdClass()],
66+
'object' => [new \stdClass()],
6567
];
6668
}
6769
}

0 commit comments

Comments
 (0)